Add the GDB pretty-printers to the Windows Rust installation

[bruno-medeiros]

The pretty printers can be made to work in Windows, as described here: http://stackoverflow.com/questions/33570021/how-to-set-up-gdb-for-debugging-rust-programs-in-windows/33570022#33570022

At a minimum the GDB pretty-printers should be added to the Windows GNU ABI Rust installation, so that they don't have to downloaded separately.

At best, the pretty-printers GDB auto-loading should work as well. I think for that the GDB auto-load info should be added to the debug information of the generated code in Windows.

@michaelwoerister Regarding this comment: #16365 (comment) , what issues did you have trying this out in Windows?

[bombless]

At the end of 2014, you can debug Rust file on gdb with pretty-printer support. So I think someone fixed that problem that bothered @michaelwoerister at that time (for once).
And for some reason the pretty-printer didn't work on Windows around Apirl, 2015.

[michaelwoerister]

Sorry , just discovered this issue now. The problem at the time was that on two out of three Windows systems that I tested things on, GDB would hang indefinitely when trying to load the program.

I'd say there is no harm in adding the python scripts to the Windows installation. About the .debug_gdb_scripts, I would want to test if it doesn't interfere with regular program execution. If it doesn't, we can add it.

[cyplo]

Hi ! Is this still an issue ?

[Mark-Simulacrum]

@michaelwoerister Do you know if this has been fixed?

[michaelwoerister]

I don't really know what the state of GDB on Windows is these days. @brson would know more about what we distribute on which platforms. My statement from before is still true: I have no problem with distributing the python scripts on Windows and someone would need to test if the .debug_gdb_scripts section causes problems. But I also still think that GDB should not be considered a tier 1 tool on Windows.

[Mark-Simulacrum]

Looking at a recent nightly, it seems we do distribute the pretty printing scripts and rust-gdb on windows. We don't insert the debug_gdb_scripts section, though I don't know why:

rust/src/librustc_trans/debuginfo/gdb.rs

Lines 85 to 88 in 80271e8

	!omit_gdb_pretty_printer_section &&
	!ccx.sess().target.target.options.is_like_osx &&
	!ccx.sess().target.target.options.is_like_windows &&
	ccx.sess().opts.debuginfo != NoDebugInfo

.

rust-nightly-x86_64-pc-windows-gnu/rustc/bin/rust-gdb
rust-nightly-x86_64-pc-windows-gnu/rust-docs/share/doc/rust/html/unstable-book/language-features/omit-gdb-pretty-printer-section.html
rust-nightly-x86_64-pc-windows-gnu/rustc/lib/rustlib/etc/gdb_rust_pretty_printing.py
rust-nightly-x86_64-pc-windows-gnu/rustc/lib/rustlib/etc/gdb_load_rust_pretty_printers.py

[michaelwoerister]

We don't insert the debug_gdb_scripts section, though I don't know why.

Because it made GDB on Windows hang or crash at the time this code was written.

[mickaelistria]

Is there any progress on this topic?