check-stage1: improper_ctypes in compiletest/raise_fd_limit on OSX

[tamird]

I'm guessing this is a result of #29546, though I'm not entirely sure why this changed;

$ make -j4 check-stage1-rpass TESTNAME=match-arm-statics
cfg: version 1.6.0-dev (9952f6435 2015-11-10)
cfg: build triple x86_64-apple-darwin
cfg: host triples x86_64-apple-darwin
cfg: target triples x86_64-apple-darwin
cfg: enabling debug assertions (CFG_ENABLE_DEBUG_ASSERTIONS)
cfg: enabling debuginfo (CFG_ENABLE_DEBUGINFO)
cfg: host for x86_64-apple-darwin is x86_64
cfg: os for x86_64-apple-darwin is apple-darwin
cfg: good valgrind for x86_64-apple-darwin is
cfg: using CC=ccache clang (CFG_CC)
cfg: using CXX=clang++ (CFG_CXX)
cfg: enabling valgrind run-pass tests (CFG_ENABLE_VALGRIND_RPASS)
cfg: valgrind-rpass command set to "/usr/local/bin/valgrind" --error-exitcode=100 --fair-sched=try --quiet --soname-synonyms=somalloc=NONE --suppressions=/Users/tamird/src/rust/src/etc/x86.supp --suppressions=/Users/tamird/src/rust/src/etc/apple-darwin.supp --tool=helgrind
cfg: disabling doc build (CFG_DISABLE_DOCS)
cfg: including test rules
cfg: lexer tooling not available, skipping lexer test...
rustc: x86_64-apple-darwin/stage0/lib/rustlib/x86_64-apple-darwin/bin/compiletest
rustc: x86_64-apple-darwin/stage0/lib/rustlib/x86_64-apple-darwin/lib/librustc_front
cp: x86_64-apple-darwin/stage1/lib/libsyntax
/Users/tamird/src/rust/src/compiletest/raise_fd_limit.rs:37:58: 37:70 error: found Rust type `usize` in foreign module, while `libc::c_uint` or `libc::c_ulong` should be used, #[deny(improper_ctypes)] on by default
/Users/tamird/src/rust/src/compiletest/raise_fd_limit.rs:37                   oldp: *mut libc::c_void, oldlenp: *mut libc::size_t,
                                                                                                                     ^~~~~~~~~~~~
/Users/tamird/src/rust/src/compiletest/raise_fd_limit.rs:38:52: 38:64 error: found Rust type `usize` in foreign module, while `libc::c_uint` or `libc::c_ulong` should be used, #[deny(improper_ctypes)] on by default
/Users/tamird/src/rust/src/compiletest/raise_fd_limit.rs:38                   newp: *mut libc::c_void, newlen: libc::size_t) -> libc::c_int;
                                                                                                               ^~~~~~~~~~~~
error: aborting due to 2 previous errors
make: *** [x86_64-apple-darwin/stage0/lib/rustlib/x86_64-apple-darwin/bin/compiletest] Error 101
make: *** Waiting for unfinished jobs....

I have a patch for this, PR to follow.

[eefriedman]

We generally don't care about warnings coming out of stage 0; that's the old compiler.

[eefriedman]

Oh, wait, this is promoted to an error; nevermind, we have to do something.