rustc does not recognize "is-like-msvc" properly?

[pravic]

Here is a gist with the target specification.

When "linker": "link.exe" is specified, I get the following:

rustc --target=i786-pc-windows-msvc.json --crate-type=dylib lib.rs
note: LINK : warning LNK4044: unrecognized option '/L'; ignored
LINK : warning LNK4044: unrecognized option '/o'; ignored
LINK : warning LNK4044: unrecognized option '/nodefaultlibs'; ignored
LINK : warning LNK4044: unrecognized option '/L'; ignored
LINK : warning LNK4044: unrecognized option '/Wl,-Bstatic'; ignored
LINK : warning LNK4044: unrecognized option '/Wl,-Bdynamic'; ignored
LINK : warning LNK4044: unrecognized option '/shared'; ignored

If omit it, rustc calls cc:

rustc --target=i786-pc-windows-msvc.json --crate-type=dylib lib.rs
error: could not exec the linker `cc`

Why? This code shows that is-like-msvc must handle it properly. And such things as "-Wl,-Bstatic" is coming from GnuLinker.

Meta:

rustc 1.9.0-nightly (bf5da36 2016-04-06)
binary: rustc
commit-hash: bf5da36
commit-date: 2016-04-06
host: i686-pc-windows-msvc
release: 1.9.0-nightly

[Aatch]

That option isn't settable from JSON. This https://github.com/rust-lang/rust/blob/master/src/librustc_back/target/mod.rs#L419, plus a few other keys are supported.

It probably should be settable from the JSON.

[pravic]

Thanks.

Guess reasonable keys which are missing are

is_like_android: false,
is_like_msvc: false,
is_like_solaris: false,

[cardoe]

Guess reasonable keys which are missing are

is_like_android: false,
is_like_msvc: false,
is_like_solaris: false,

Was there a reason for leaving the android and solaris ones out?

[pravic]

Issue was fixed at #32823 and landed with 2016-04-12 nightly.

[pravic]

Idk about testcases, may be they needed for this.