error for recursion limit should give instructions for increasing it

[durka]

I thought it used to do this, but I could be making it up.

[nagisa]

We still do, however there many different cases where such recursion error may happen. I’m not sure setting #[recursion_limit="256"] would do anything for, say, trait instantiation recursion thing.

[durka]

It doesn't (anymore?) if you exceed the limit during macro expansion.
On Jun 29, 2016 18:35, "Simonas Kazlauskas" notifications@github.com
wrote:

We still do, however there many different recursion limits. I’m not sure
setting #[recursion_limit="256"] would do anything for, say, trait
instantiation recursion thing.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34565 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAC3n3bcm46cnJ-7BJILgC-28m51sYuiks5qQvMWgaJpZM4JBnW8
.

[durka]

I'm talking about this one to be clear.

[nagisa]

IMO the optimal fix would be to introduce a helper function or macro in a form of

check_recursion_limit!(..., current_depth, error_msg, fmt_args)

and use it everywhere where we currently emit recursion error.

[durka]

Fixed by #39655 (re: #34565 (comment), see #40198).