Skip to content

libstd: Some fs tests check localized error messages and fail on non-English versions of Windows #34628

Closed
@petrochenkov

Description

@petrochenkov

The tests in question:

fs::tests::file_test_iounlinking_invalid_path_should_raise_condition
fs::tests::invalid_path_raises
fs::tests::open_flavors

They check that the error messages from OS contain the string "The parameter is incorrect" literally, but on non-English OS versions the error messages are translated.

cc @pitdicker @alexcrichton
Feel free to close this issue if the fix is non-trivial, this is only a minor inconvenience - make check fails and the tests have to be skipped manually by touching tmp/check-stage2-T-x86_64-pc-windows-gnu-H-x86_64-pc-windows-gnu-std.ok.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions