“type must outlive the static lifetime” makes no sense

[nagisa]

For the following code

pub trait Arbitrary: Sized + 'static {}

impl<'a, A: Clone> Arbitrary for ::std::borrow::Cow<'a, A> {}

The diagnostic looks like this:

error[E0477]: the type `std::borrow::Cow<'a, A>` does not fulfill the required lifetime
 --> <anon>:3:20
  |
3 | impl<'a, A: Clone> Arbitrary for ::std::borrow::Cow<'a, A> {}
  |                    ^^^^^^^^^
  |
  = note: type must outlive the static lifetime

The note here makes no sense, because the static lifetime is the longest lifetime of all and cannot really be outlived. We should reword the note so it doesn’t say “outlive”.

Bonus points for explaining where the lifetime requirement comes from, because it is not entirely clear what here introduces the requirement, when the trait and implementation definitions aren’t so close together.

[GuillaumeGomez]

I'll fix the simple version.

PS: and try to do the big part later on.

[nagisa]

In addition to everything, the span is pretty bad. The type which must satisfy any of the lifetimes here is the implementor, not the trait.

[steveklabnik]

Triage; this now says

  = note: but lifetime parameter must outlive the static lifetime

So, not fixed yet!

[gilescope]

Still makes not much sense in 2022.

[hnyls2002]

Still makes not much sense in 2023