Skip to content

UI test output should be patch compatible #41948

Closed
@nikomatsakis

Description

@nikomatsakis

@eddyb made the good point that it'd be nice if the diff produced by UI tests were something one could easily feed into patch. Also, the role of - as "expected" and + as "actual" is correct, but the ordering is backwards from what diff uses. It'd be nice to change the call to diff so that instead of doing diff_lines(actual, expected) it did diff_lines(expected, actual) (and then making "left" print - etc).

(Another question, can we add unit tests here somehow?)

cc @cengizio

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions