Skip to content

Remove TypeIdHasher and replace it with StableHasher in debuginfo and symbol hashing #50424

Closed
@michaelwoerister

Description

@michaelwoerister

At the moment we have two implementations for hashing Ty values, the StableHasher (which is used for incr. comp. and TypeId) and the TypeIdHasher which was formerly used for TypeId and has some leftover uses in symbol hash generation and debuginfo.

We should be able to switch the two remaining uses to StableHasher quite easily. This might also be a small performance win, since StableHasher is more optimized.

cc @rust-lang/wg-compiler-performance

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.I-compiletimeIssue: Problems and improvements with respect to compile times.WG-compiler-performanceWorking group: Compiler Performance

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions