Skip to content

[nll] introduce dirty list to dataflow #51813

Closed
@nikomatsakis

Description

@nikomatsakis

I've been examining profiling results of the clap-rs test case (I am profiling the #51538 branch, more specifically). One clear hot spot is the do_dataflow, which accounts for 18% of MIR borrow check time. It is a fairly naive "fixed point" iteration that propagate bits around. It can (probably) be improved by introducing a "dirty list" to avoid processing basic blocks whose contents have not changed.

Metadata

Metadata

Assignees

Labels

NLL-performantWorking towards the "performance is good" goalT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions