Skip to content

Tests are not rebuilt when codegen is rebuilt #52719

Closed
@glandium

Description

@glandium

I was in the middle of bisecting on system llvm and running x.py test src/libstd --stage 1 when I noticed that, in fact, while each step was rebuilding the compiler with the changed llvm correctly, the test that was being run was never recompiled, such that the same one was always running, and my bisect was guided by wrong results.

STR:

  • Run x.py test src/libstd --stage 1 once
  • Touch anything that is part of e.g. librustc_codegen_llvm.so, e.g. src/librustc_llvm/lib.rs
  • Run x.py test src/libstd --stage 1 again

Expected result:

  • Both librustc_codegen_llvm.so and the test are rebuilt, and the rebuilt test executed.

Actual result:

  • librustc_codegen_llvm.so is rebuilt, the test is not, and the test built before the codegen changes is executed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions