Closed
Description
To resolve #48879 we added --compare-mode=nll
. It allows us to keep track of whether the diagnostics deviate, and in what fashion, for the whole ui/
test suite.
We should have something similar for the 2018 edition. That would force us to be honest about how much things are going to change for people who try to upgrade their edition.
(Also, I believe such a mode would have caught #52967)
The new compare-mode=2018
could either be added as a new thing on its own, or we could replace the existing compare-mode=nll
with compare-mode=2018
.
- The main motivation I can imagine for replacing rather than a pure addition would be to minimize the impact on the time our autobuilds spend in the
ui/
test suite. I would like feedback from @rust-lang/infra about which route is best here.