Skip to content

Deduplicate Cargo in the RLS on CI #53005

Closed
@alexcrichton

Description

@alexcrichton

Once #52919 lands we'll have updated the RLS which updates racer, and racer has recently picked up a dependency on the cargo crate. Unfortunately though this is a cargo crate from crates.io, which differs from the src/tools/cargo crate in-tree. This means that when we build the RLS it's linking against two optimized versions of Cargo, which not only takes up a good deal of space but also takes up a good deal of build time.

In talking with @nrc on IRC one solution here would be to avoid using racer's cargo feature. The RLS already depends on cargo-the-crate and should be able to provide the functionality necessary for racer, for example implementing racer's ProjectModelProvider trait

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions