Skip to content

generalize "async-idents" edition compatibility lint to other 2018 keywords #53077

Closed
@zackmdavis

Description

@zackmdavis

The Edition Guide claims that await and try will be keywords in Edition 2018. On Discord, @scottmcm pointed out that one compatibility lint could check for all the new keywords. Right now we have async_idents to check for async, but it makes sense to just have one lint (rust_2018_keyword_idents?) instead of three, because there's not going to a situation where you would want, e.g., #[warn(async_idents)] but #[allow(try_idents)].

async_idents is already on the beta train, so if we do this, then we need to either:

  • (preferred) do it before the mid-September 1.29 cutoff and backport it to 1.29 beta, or
  • register_renamed for async_idents

Metadata

Metadata

Assignees

Labels

A-edition-2018Area: The 2018 editionA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.F-rust_2018_preview`#![feature(rust_2018_preview)]`

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions