Skip to content

NLL: need to run the run-pass tests under compare-mode=nll #53764

Closed
@pnkfelix

Description

@pnkfelix

The NLL work has been coasting for a long time by focusing on either adding tests that opt into NLL (via #[feature(nll)]) or using compare-mode=nll to exercise the ui/ test suite.

This obviously was imperfect, since it skipped everything outside of ui/ that didn't use the explicit opt-in, so we have been missing those cases.

  • (We resolved this for compile-fail/ by porting those tests to the ui/ directory.)

At this point, we really should be exercising NLL against (at least) the run-pass test suite.

  • We might do this by hacking compiletest to have some sort of compare-mode=nll that works with the run-pass/ suite.
  • Or we might do it by "just" migrating all of the run-pass/ tests to the ui/ directory.
    • Right now, this second option is the plan of record.

Below is a task list of directories to be ported from src/test/run-pass/*/:

Metadata

Metadata

Assignees

Labels

A-NLLArea: Non-lexical lifetimes (NLL)P-highHigh priority

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions