Closed
Description
#53916 (comment) noted that the submodules
setting of config.toml
is not very discoverable.
I have set it to false
in all my trees and update my submodules manually, because I've had work destroyed multiple times when I changed submodule contents and x.py
killed them without asking by force updating the submodule to the commit checked into the rustc repo.
There are a few (not mutually exclusive) ways to improve this:
- don't update submodules if they are dirty (modified files, new files)
- don't update submodules if the current commit is newer than the one x.py wants to update to (so only go forward automatically, not backwards)
- set
submodules = false
by default (might inconvenience developers that never touch submodules, I am biased here due to touching clippy and miri on a very regular basis)