Skip to content

should survey uses of #[rustc_error] and see if they can be replaced with // compile-pass #55505

Closed
@pnkfelix

Description

@pnkfelix

Discussing some of the difficulties with #54528 with @nikomatsakis led them to remind me that we originally introduced #[rustc_error] because we didn't have a way to express // compile-pass to the test infrastructure.

But now we do

and it would make sense for us to try to migrate instances of #[rustc_error] to use // compile-pass when possible.

(I think the main case where it is not possible are instances of // revisions where at least one of the revisions compiles successfully and another does not.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions