cannot mutate statics in initalizer of another static

[Mark-Simulacrum]

https://crater-reports.s3.amazonaws.com/beta-1.32-1/beta-2018-12-05/gh/oxidizers.drdns/log.txt

Dec 08 20:04:10.309 INFO [stderr] error: cannot mutate statics in the initializer of another static
Dec 08 20:04:10.309 INFO [stderr]    --> src/buffer.rs:279:17
Dec 08 20:04:10.309 INFO [stderr]     |
Dec 08 20:04:10.309 INFO [stderr] 279 |     x: unsafe { &mut STDOUT_BUFFER_SPACE as *mut [u8] as *mut u8 },
Dec 08 20:04:10.309 INFO [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^
Dec 08 20:04:10.309 INFO [stderr] 
Dec 08 20:04:10.309 INFO [stderr] error: cannot mutate statics in the initializer of another static
Dec 08 20:04:10.310 INFO [stderr]    --> src/buffer.rs:293:17
Dec 08 20:04:10.310 INFO [stderr]     |
Dec 08 20:04:10.310 INFO [stderr] 293 |     x: unsafe { &mut STDERR_BUFFER_SPACE as *mut [u8] as *mut u8 },
Dec 08 20:04:10.310 INFO [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^
Dec 08 20:04:10.310 INFO [stderr] 

[oli-obk]

cc @tarcieri

Repro

static mut STDERR_BUFFER_SPACE: [u8; 42] = [0u8; 42];

pub static mut STDERR_BUFFER: *mut [u8] = unsafe { &mut STDERR_BUFFER_SPACE };

I'm going to fix the regression, but I just want to note that https://github.com/oxidizers/drdns/blob/98c1153a09642c2a5d8d2ed77ef7d9429d94995a/src/buffer.rs#L292 is very dangerous to use. This looks like another argument for #53639

[tarcieri]

FWIW the code in question is some mechanically translated C with the translation performed by corrode. I have pretty much abandoned that project.

[pnkfelix]

triage: P-high.