Skip to content

Bors policy question: Auto-reassignment on r+ #59489

Closed
@Centril

Description

@Centril

Currently, the behavior of @bors is that whenever you @bors r+ or @bors r=UserFooBar, the reviewer doesn't change. However, this makes it less clear who the current reviewer is. For example, the assignee might not have even looked at the PR before someone else has r+ed it. I believe having an up to date assignee more frequently would simplify triage. Also, as @pnkfelix noted:

if one steals review action, it certainly seems like one should take on the burden of assignment as well.

While one could r? @Centril @bors r+ and such all the time, people often forget this and it instead causes churn to do so manually. As an example, there's #59468.

Instead, I propose that:

  • Whenever you r+ a PR, you get r? as well.
  • If you r=UserFooBar, and @UserFooBar is not assigned, then they will be assigned.

The tagged teams are those that typically use @bors in this repo or perform triage and who will therefore be affected by this policy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-langRelevant to the language team, which will review and decide on the PR/issue.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions