Replace `always_inline` with `inline(always)`?

[kud1ing]

librustc/middle/trans/adt.rs is the only place to use the form #[always_inline].
Other places uses #[inline(always)].

Could this be unified?

[luqmana]

It doesn't seem like #[always_inline] is respected at all. I'm guessing a mistype.

[kud1ing]

src/rt/rust_globals.h has some #define ALWAYS_INLINE __attribute((always_inline)) INLINE.
ALWAYS_INLINE is used in src/rt/arch/i386/sp.h and src/rt/arch/x86_64/sp.h.

Maybe this is a special or an ancient form?

[luqmana]

Yep, but those are for c++ in the runtime.

[kud1ing]

I am not sure whether __attribute((always_inline)) would query the values set by #[always_inline].

[luqmana]

They wouldn't, #[foo] are attributes in Rust code, while __attribute((always_inline)) is c/c++ compiler specific function attribute.