Skip to content

ninja is only used in Windows builds on CI. #70469

Open
@eddyb

Description

@eddyb

AFAICT this is the only thing that adds --enable-ninja, and it's Windows-only:

if isWindows; then
mkdir ninja
curl -o ninja.zip "${MIRRORS_BASE}/2017-03-15-ninja-win.zip"
7z x -oninja ninja.zip
rm ninja.zip
ciCommandSetEnv "RUST_CONFIGURE_ARGS" "${RUST_CONFIGURE_ARGS} --enable-ninja"
ciCommandAddPath "$(pwd)/ninja"
fi

We also autodetect ninja and use it, but only for MSVC specifically (#43767 / #44084).

On top of being (supposedly) faster than relying on make, IME ninja also has less log spew when building LLVM (but it's unclear if it would help on CI, see #70468).

cc @rust-lang/infra

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions