"as bool" does not properly convert its argument.

[thomcc]

foo as bool should result in an i1, not an i8. This can lead to various unexpected or hard to debug behavior. See:

rusti> 3 as bool as u8
3
rusti> (3 as bool)
true
rusti> (2 as bool)
true
rusti> std::bool::xor(true, true)
false
rusti> std::bool::xor((3 as bool), (2 as bool))
true
rusti> 0xffff as bool as u8
255
rusti> 0xff00 as bool
false

[thestinger]

I think we're handling bool very wrong right now. It should be stored as u8 on the stack, but passed as i1 zeroext in parameters like clang. It should be turned into an i1 immediately after a load and extended to a u8 for a store.

[thestinger]

I don't think we should allow as conversions on bool at all because you can use == 0. Re-nominating for the backwards compatible milestone.

[metajack]

Visiting for triage. Looks like this will be fixed shortly. Nothing to add.