ui simd-intrinsic-generic-bitmask test fails on big endian

[infinity0]

version 1.44.1 s390x ppc64 powerpc (but the failures have been around ever since the test was introduced)

I will be adding an ignore-endian-big feature as part of #74829, just wanted to confirm the failure is OK to ignore:

---- [ui] ui/simd/simd-intrinsic-generic-bitmask.rs stdout ----


executing "/<<PKGBUILDDIR>>/build/powerpc64-unknown-linux-gnu/stage2/bin/rustc" "/<<PKGBUILDDIR>>/src/test/ui/simd/simd-intrinsic-generic-bitmask.rs" "-Zthreads=1" "--target=powerpc64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/<<PKGBUILDDIR>>/build/powerpc64-unknown-linux-gnu/test/ui/simd/simd-intrinsic-generic-bitmask/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/<<PKGBUILDDIR>>/build/powerpc64-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=powerpc64-linux-gnu-gcc" "-L" "/<<PKGBUILDDIR>>/build/powerpc64-unknown-linux-gnu/test/ui/simd/simd-intrinsic-generic-bitmask/auxiliary"
------stdout------------------------------

------stderr------------------------------

------------------------------------------
executing "/<<PKGBUILDDIR>>/build/powerpc64-unknown-linux-gnu/test/ui/simd/simd-intrinsic-generic-bitmask/a"
------stdout------------------------------

------stderr------------------------------
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `10`,
 right: `5`', /<<PKGBUILDDIR>>/src/test/ui/simd/simd-intrinsic-generic-bitmask.rs:52:9
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: std::panicking::rust_panic_with_hook
   6: rust_begin_unwind
   7: std::panicking::begin_panic_fmt
   8: simd_intrinsic_generic_bitmask::main
   9: std::rt::lang_start::{{closure}}
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

------------------------------------------

error: test run failed!
status: exit code: 101
command: "/<<PKGBUILDDIR>>/build/powerpc64-unknown-linux-gnu/test/ui/simd/simd-intrinsic-generic-bitmask/a"
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `10`,
 right: `5`', /<<PKGBUILDDIR>>/src/test/ui/simd/simd-intrinsic-generic-bitmask.rs:52:9
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: std::panicking::rust_panic_with_hook
   6: rust_begin_unwind
   7: std::panicking::begin_panic_fmt
   8: simd_intrinsic_generic_bitmask::main
   9: std::rt::lang_start::{{closure}}
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

------------------------------------------

CC @gnzlbg who wrote the test originally

[infinity0]

I just realised that src/test/ui/simd/simd-intrinsic-generic-select.rs has a comment saying "behavior of simd_select_bitmask is endian-specific" so I figure this test will be OK to ignore on big-endian as well. Will do that as part of my follow-up to #74829.

[Lonami]

Rather than ignoring it, wouldn't it be better to have the same test adapted for big endian and compiled conditionally? Being dependant on endianess seems to make the test even more important to test.

[infinity0]

Some people think it's not worth the effort. See discussion on #74829.