Rust fails to compile on Linux SUSE, SLES11, GCC 4.8.0

[orenbenkiki]

Full make results are pretty large, here are the results of running make a 2nd time (following a configure in a just-cloned directory):

$ make
cfg: build triple x86_64-unknown-linux-gnu
cfg: host triples x86_64-unknown-linux-gnu
cfg: target triples x86_64-unknown-linux-gnu
cfg: host for x86_64-unknown-linux-gnu is x86_64
cfg: os for x86_64-unknown-linux-gnu is unknown-linux-gnu
cfg: using gcc
cfg: no node found, omitting docs
cfg: no llnextgen found, omitting grammar-verification
make[1]: Entering directory `/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv'
make -C /nfs/iil/home/obenkiki/private/rust/rust-HEAD//rt/x86_64-unknown-linux-gnu/stage0/libuv -f /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/Makefile  \
                SRCDIR=/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv builddir_name=
make[2]: Entering directory `/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/rt/x86_64-unknown-linux-gnu/stage0/libuv'
gcc --std=c89 -pedantic -Wall -Wextra -Wno-unused-parameter -I/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include -I/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv-private -I/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/src -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DRUST_NDEBUG -fno-omit-frame-pointer -DUSE_UTF8 -O2 -m64 -fPIC  -c /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/src/unix/async.c -o src/unix/async.o
In file included from /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv.h:67:0,
                 from /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/src/unix/async.c:21:
/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv-private/uv-unix.h:116:1: error: unknown type name ‘pthread_rwlock_t’
 typedef pthread_rwlock_t uv_rwlock_t;
 ^
/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv-private/uv-unix.h:140:1: error: unknown type name ‘pthread_barrier_t’
 typedef pthread_barrier_t uv_barrier_t;
 ^
In file included from /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/src/unix/async.c:21:0:
/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv.h:343:42: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default]
                                   struct addrinfo* res);
                                          ^
/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv.h:343:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
make[2]: *** [src/unix/async.o] Error 1
make[2]: Leaving directory `/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/rt/x86_64-unknown-linux-gnu/stage0/libuv'
make[1]: *** [/nfs/iil/home/obenkiki/private/rust/rust-HEAD//rt/x86_64-unknown-linux-gnu/stage0/libuv] Error 2
make[1]: Leaving directory `/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv'
make: *** [rt/x86_64-unknown-linux-gnu/stage0/libuv/libuv.a] Error 2

[pnkfelix]

visiting for triage, email from 2013-09-02.

Weird that those pthread typedefs are not available. I wonder if this is possibly fixed via a libuv update?

(Maybe an even better question: @orenbenkiki can you build libuv on its own on this platform? I.e., is the bug that we are misconfiguring our build of libuv? Or are we just inheriting a bug from libuv?)

[orenbenkiki]

This seems similar to the issue people had in JuliaLang/julia#2502 (and yes, I am running an "Enterprise Linux", may god have mercy on my soul). This pointed at joyent/libuv#737 as a likely fix of the problem. I manually changed the OS variable to PLATFORM in the .mk files and it fixed the problem. It seems the rust libuv from https://github.com/brson/libuv is lagging behind the https://github.com/joyent/libuv version, so I guess the issue becomes "update rust to use a more updated version of libuv"?

[huonw]

A convenient coincidence: @alexcrichton opened a PR upgrading libuv (#8994) 2 hours ago.

[alexcrichton]

Is this still relevant?

[orenbenkiki]

Probably not, I think the library has been refreshed.