SIGSEGV from rustc while building crate `legion`

[alex5nader]

Code

I am not sure what part of legion is causing this. I have not encountered this issue for any other crates.

Meta

rustc --version --verbose:

rustc 1.47.0 (18bf6b4f0 2020-10-07)
binary: rustc
commit-hash: 18bf6b4f01a6feaf7259ba7cdae58031af1b7b39
commit-date: 2020-10-07
host: x86_64-unknown-linux-gnu
release: 1.47.0
LLVM version: 11.0

Error output

   Compiling legion v0.3.1 (/data/Projects/legion)
error: could not compile `legion`.

Caused by:
  process didn't exit successfully: `rustc --crate-name legion --edition=2018 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 --cfg 'feature="codegen"' --cfg 'feature="crossbeam-channel"' --cfg 'feature="crossbeam-events"' --cfg 'feature="default"' --cfg 'feature="erased-serde"' --cfg 'feature="legion_codegen"' --cfg 'feature="parallel"' --cfg 'feature="rayon"' --cfg 'feature="serde"' --cfg 'feature="serialize"' -C metadata=14f1150a42ae3e4b -C extra-filename=-14f1150a42ae3e4b --out-dir /data/Projects/legion/target/debug/deps -C incremental=/data/Projects/legion/target/debug/incremental -L dependency=/data/Projects/legion/target/debug/deps --extern bit_set=/data/Projects/legion/target/debug/deps/libbit_set-0f027bbe9088639b.rmeta --extern crossbeam_channel=/data/Projects/legion/target/debug/deps/libcrossbeam_channel-e02935c1a92635b3.rmeta --extern derivative=/data/Projects/legion/target/debug/deps/libderivative-027c3cec12a884ca.so --extern downcast_rs=/data/Projects/legion/target/debug/deps/libdowncast_rs-818a53b23fc7be82.rmeta --extern erased_serde=/data/Projects/legion/target/debug/deps/liberased_serde-c8566e1a0c06d2b3.rmeta --extern itertools=/data/Projects/legion/target/debug/deps/libitertools-4b46418de185c381.rmeta --extern legion_codegen=/data/Projects/legion/target/debug/deps/liblegion_codegen-7fefbee3b51a1a22.so --extern parking_lot=/data/Projects/legion/target/debug/deps/libparking_lot-1282ab6a8685ce14.rmeta --extern paste=/data/Projects/legion/target/debug/deps/libpaste-69df8912f33518e2.so --extern rayon=/data/Projects/legion/target/debug/deps/librayon-1e861157ad884d7a.rmeta --extern serde=/data/Projects/legion/target/debug/deps/libserde-2a6ef3a1ac05b029.rmeta --extern smallvec=/data/Projects/legion/target/debug/deps/libsmallvec-7e54452c7c62a719.rmeta --extern thiserror=/data/Projects/legion/target/debug/deps/libthiserror-e30ede5540027b3b.rmeta --extern uuid=/data/Projects/legion/target/debug/deps/libuuid-1b1ed382cc39f9ea.rmeta` (signal: 11, SIGSEGV: invalid memory reference)

Backtrace

#0  free (ptr=0x48c2df416aec43d6) at ../jemalloc/src/jemalloc.c:2393
#1  0x00007ffff3511bcc in <smallvec::SmallVec<A> as core::ops::drop::Drop>::drop ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#2  0x00007ffff35bf011 in <rustc_resolve::late::LateResolutionVisitor as rustc_ast::visit::Visitor>::visit_local ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#3  0x00007ffff35be822 in <rustc_resolve::late::LateResolutionVisitor as rustc_ast::visit::Visitor>::visit_block ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#4  0x00007ffff35c07d0 in <rustc_resolve::late::LateResolutionVisitor as rustc_ast::visit::Visitor>::visit_fn ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#5  0x00007ffff3549f9c in rustc_ast::visit::walk_assoc_item ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#6  0x00007ffff35cc54e in rustc_resolve::late::LateResolutionVisitor::with_generic_param_rib ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#7  0x00007ffff35c2f39 in rustc_resolve::late::LateResolutionVisitor::resolve_item ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#8  0x00007ffff355696e in rustc_ast::visit::walk_item ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#9  0x00007ffff35c2473 in rustc_resolve::late::LateResolutionVisitor::resolve_item ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#10 0x00007ffff355696e in rustc_ast::visit::walk_item ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#11 0x00007ffff35c2473 in rustc_resolve::late::LateResolutionVisitor::resolve_item ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#12 0x00007ffff3547d42 in rustc_ast::visit::walk_crate ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#13 0x00007ffff3588ac7 in rustc_resolve::Resolver::resolve_crate ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#14 0x00007ffff08f3c97 in rustc_interface::passes::configure_and_expand_inner ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#15 0x00007ffff08d06c9 in rustc_interface::passes::configure_and_expand::{{closure}} ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#16 0x00007ffff08aaecf in rustc_data_structures::box_region::PinnedGenerator<I,A,R>::new ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#17 0x00007ffff08f2965 in rustc_interface::passes::configure_and_expand ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#18 0x00007ffff0913f73 in rustc_interface::queries::Queries::expansion ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#19 0x00007ffff05bd887 in rustc_interface::queries::<impl rustc_interface::interface::Compiler>::enter ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#20 0x00007ffff0551f27 in rustc_span::with_source_map ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#21 0x00007ffff05bf513 in rustc_interface::interface::create_compiler_and_run ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#22 0x00007ffff059d9fa in scoped_tls::ScopedKey<T>::set ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#23 0x00007ffff05b2957 in std::sys_common::backtrace::__rust_begin_short_backtrace ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#24 0x00007ffff053bdae in core::ops::function::FnOnce::call_once{{vtable-shim}} ()
   from /home/noobstar/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/../lib/librustc_driver-ff4ec557f69b94a7.so
#25 0x00007fffef949f5a in <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once ()
    at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/alloc/src/boxed.rs:1042
#26 <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once ()
    at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/alloc/src/boxed.rs:1042
#27 std::sys::unix::thread::Thread::new::thread_start () at library/std/src/sys/unix/thread.rs:87
#28 0x00007fffef84f606 in ?? () from /usr/lib/libpthread.so.0
#29 0x00007fffef775753 in clone () from /usr/lib/haswell/libc.so.6

[alex5nader]

Building legion on Rust 1.46.0 does work.

rustc --version --verbose:

rustc 1.46.0 (04488afe3 2020-08-24)
binary: rustc
commit-hash: 04488afe34512aa4c33566eb16d8c912a3ae04f9
commit-date: 2020-08-24
host: x86_64-unknown-linux-gnu
release: 1.46.0
LLVM version: 10.0

[jyn514]

Possible duplicate of #77849

[ehuss]

I'm able to reproduce this, although it is finicky. I'm able to reproduce on stable, and as far back as 1.43. I've been having a hard time bisecting to a specific change, since it is a little inconsistent (it can take a few hundred incremental builds before it fails). The failures seem to start around 126ad2b (#68708), although it might be earlier.

I can only repro on my main linux system, but I can't seem to repro on a VM.

It seems to always fail with a call to free on an invalid pointer inside LateResolutionVisitor. It doesn't matter if it is built with jemalloc or not.

I might keep poking at it for a bit, but I think I'm unlikely to make any breakthroughs.

[apiraino]

just out of curiosity, are there conditions that could accellerate the "reproducibility"? Like, if it's a memory exhaustion and allocations fail, could that theoretically happen sooner on a system (hand-wavy speaking) with resources artificially kept busy?

[Aaron1011]

@ehuss: What commit of legion did you build?