Skip to content

Restore Servo’s style crate in cargotest? #79404

Open
@SimonSapin

Description

@SimonSapin

src/tools/cargotest in this repository runs cargo test for a few crates as part of CI, including some of https://github.com/servo/servo/. This used to select the selectors and stylo_tests crates, whose dependency graph include most Servo crates that don’t rely on unstable language or std features.

In #54451 (comment) stylo_tests was removed. This in turn greatly reduced the coverage of what ends up being compiled during this test, since stylo_tests depended on the style crate which is one of the big components. With only the selectors crate and its dependency graph, much less of Servo is compiled which makes including Servo in cargotest less useful. On the other hand, compiling more stuff might increase the time taken by CI.

Some options here are:

// Only test Stylo a.k.a. Quantum CSS, the parts of Servo going into Firefox.
// This takes much less time to build than all of Servo and supports stable Rust.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcT-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions