Skip to content

compiletest: Not all diff installations have --color #80037

Closed
@camelid

Description

@camelid

There is some rustdoc-related code in compiletest that uses the diff command-line tool; however, it passes the --color flag to diff, which diff does not accept on my system (macOS). We should probably use git diff --no-index instead of diff since it will have colors and will automatically use a pager. We may also want to pass the --minimal flag to diff/git diff; the manual page says:

--minimal
Spend extra time to make sure the smallest possible diff is produced.

See also #79991 (comment).

cc @jyn514

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions