rustdoc prints `<unknown>` as name of crate root

[camelid]

//! [my_module]

mod my_module {}

warning: public documentation for `<unknown>` links to private item `my_module`
 --> foo.rs:1:6
  |
1 | //! [my_module]
  |      ^^^^^^^^^ this item is private
  |
  = note: `#[warn(private_intra_doc_links)]` on by default
  = note: this link will resolve properly if you pass `--document-private-items`

warning: 1 warning emitted

It should say foo instead.

[jyn514]

Relevant code:

rust/src/librustdoc/passes/collect_intra_doc_links.rs

Lines 2058 to 2066 in 7f82ddb

	fn privacy_error(cx: &DocContext<'_>, item: &Item, path_str: &str, dox: &str, link: &MarkdownLink) {
	let sym;
	let item_name = match item.name {
	Some(name) => {
	sym = name.as_str();
	&*sym
	}
	None => "<unknown>",
	};

rust/src/librustdoc/visit_ast.rs

Lines 73 to 80 in 7f82ddb

	crate fn visit(mut self, krate: &'tcx hir::Crate<'_>) -> Module<'tcx> {
	let mut top_level_module = self.visit_mod_contents(
	krate.item.span,
	&Spanned { span: rustc_span::DUMMY_SP, node: hir::VisibilityKind::Public },
	hir::CRATE_HIR_ID,
	&krate.item.module,
	None,
	);

I think the fix is to use the crate name instead of None.

[jyn514]

Also, I would be curious to see if you can remove Module::name altogether by using tcx.item_name:

rust/src/librustdoc/clean/mod.rs

Lines 232 to 237 in 7f82ddb

	let what_rustc_thinks = Item::from_hir_id_and_parts(
	self.id,
	self.name,
	ModuleItem(Module { is_crate: self.is_crate, items }),
	cx,
	);

. That might break renamed modules maybe? I don't remember how modules interact with re-exports.