Skip to content

coercions perf benchmark regressed by 3% to 14% after bidi lint addition #90514

Open
@pnkfelix

Description

@pnkfelix

Spawned off of #90462 (comment)

A bunch of benchmarks regressed. Its understandable to see overhead from a new on-by-default lint, especially one that operates at the lexing phase (and thus will affect a very broad range of benchmarks).

But coercions seems like it was hit particularly hard in some cases. I have to imagine we could do something to address that 14% regression to coercions check. (Note though that the biggest regressions are only on incremental builds of coercions. Full builds of coercions regressed by "only" 6.7%.)

Metadata

Metadata

Assignees

Labels

A-frontendArea: Compiler frontend (errors, parsing and HIR)A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.A-parserArea: The lexing & parsing of Rust source code to an ASTC-optimizationCategory: An issue highlighting optimization opportunities or PRs implementing suchI-slowIssue: Problems and improvements with respect to performance of generated code.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions