Standard library documentation documents trait implementations for the miniz_oxide crate

[FSMaxB]

While looking at the standard library documentation of std::result::Result I found some trait implementations of From<StreamResult> documented there. These belong to the miniz_oxide crate. I do not think this trait implementation belongs in the standard library documentation.

See https://doc.rust-lang.org/stable/std/result/enum.Result.html#impl-From%3CStreamResult%3E
This is also present in the standard library documentation that rustup installs locally.

Meta

The Version string on docs.rust-lang.org is Version 1.56.1 (59eed8a2a 2021-11-01) at the time of writing.

I was told on the #docs-rs discord channel to tag @GuillaumeGomez in this issue.

[GuillaumeGomez]

They should definitely not be displayed.

[GuillaumeGomez]

After taking a look, I have to admit that I have no idea how to handle this... We could add #[doc(hidden)] on miniz_oxide implementation I guess, but do we want this?

Maybe you have an idea @camelid @notriddle ?

[notriddle]

This seems related to #88696.

[GuillaumeGomez]

Thanks for the link!

[camelid]

I think this is exactly what #[doc(masked)] is for, isn't it?

[GuillaumeGomez]

It is, but the miniz-oxide crate might still want to show these impls though.

EDIT: nevermind, you're absolutely right @camelid. I confused it with doc(hidden)...