Skip to content

Error message for cmake could meet bar set by that for ninja #90679

Closed
@pnkfelix

Description

@pnkfelix

I tried to build on a new machine. Got this message:

thread 'main' panicked at '

couldn't find required command: "cmake"

'

Which I'm used to.

I googled a bit, installed cmake, figured out how to get PATH set up, et cetera.

Then I built again. And got this:

Couldn't find required command: ninja (or ninja-build)

You should install ninja as described at
<https://github.com/ninja-build/ninja/wiki/Pre-built-Ninja-packages>,
or set `ninja = false` in the `[llvm]` section of `config.toml`.
Alternatively, set `download-ci-llvm = true` in that `[llvm]` section
to download LLVM rather than building it.

I'm not sure, but: Isn't cmake solely necessary in our build for building LLVM? if that's the case, then shouldn't both the cmake failure and the ninja failure be providing the same level of feedback (namely, suggesting that one side-step building LLVM altogether as an alternative option to downloading and installing cmake)?

(Or is the assumption here that cmake will be used by so many crates, people should just bite bullet and install it? Even so, we could give better guidance up front about where to look for it.)

Metadata

Metadata

Assignees

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-enhancementCategory: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions