`rustdoc --passes=list` doesn't show a deprecation warning

[jyn514]

I tried this command: rustdoc --passes=list

I expected to see this happen: rustdoc shows a warning, the way it does for any other value you pass to --passes:

$ rustdoc +nightly --passes check-invalid-html-tags
warning: the `passes` flag is deprecated
  |
  = note: see issue #44136 <https://github.com/rust-lang/rust/issues/44136> for more information

Instead, this happened: Rustdoc gives no warning and lists all passes.

Meta

rustdoc --version

rustdoc 1.58.0-nightly (e90c5fbbc 2021-11-12)

[jyn514]

Mentoring instructions: Move this check

rust/src/librustdoc/config.rs

Lines 372 to 373 in 3b263ce

	// check for deprecated options
	check_deprecated_options(matches, &diag);

earlier to before --passes=list is processed:

rust/src/librustdoc/config.rs

Lines 330 to 360 in 3b263ce

	if matches.opt_strs("passes") == ["list"] {
	println!("Available passes for running rustdoc:");
	for pass in passes::PASSES {
	println!("{:>20} - {}", pass.name, pass.description);
	}
	println!("\nDefault passes for rustdoc:");
	for p in passes::DEFAULT_PASSES {
	print!("{:>20}", p.pass.name);
	println_condition(p.condition);
	}
	if nightly_options::match_is_nightly_build(matches) {
	println!("\nPasses run with `--show-coverage`:");
	for p in passes::COVERAGE_PASSES {
	print!("{:>20}", p.pass.name);
	println_condition(p.condition);
	}
	}
	fn println_condition(condition: Condition) {
	use Condition::*;
	match condition {
	Always => println!(),
	WhenDocumentPrivate => println!(" (when --document-private-items)"),
	WhenNotDocumentPrivate => println!(" (when not --document-private-items)"),
	WhenNotDocumentHidden => println!(" (when not --document-hidden-items)"),
	}
	}
	return Err(0);
	}

[inashivb]

@rustbot claim