Skip to content

Rustdoc new crate filter location visually unpolished #93240

Closed
@steffahn

Description

@steffahn

I took a few notes while looking at nightly rustc docs:

Screenshot_20220123_165956

@rustbot label T-rustdoc, C-bug, C-enhancement, A-rustdoc-ui

The sans serif vs. serif is clearly a bug. That’s looking terrible.

The location being in a place that moves horizontally is suboptimal; changing that would be an enhancement. The font size is ridiculously high (because it’s part of a “title”, I guess?). I like the thing no longer being inside of the search bar like it used to be, so I’m not suggesting any reverts, just more polishing work. Maybe this option could be placed e.g. still roughly next to the “Results for …” heading, but right-justified so it doesn’t move around when I change my search term, and also in a normal / more reasonable size. E.g. saying something like “search in [all crates]”.

By the way, something not indicated in the picture that I just noticed: if it says “… in [All crates]”, I don’t think the “All” should be capitalized anymore.

The question of whether or not it’s necessary for rustdoc to parrot my search term at all is one I don’t care all that much about. If there’s any benefit to keeping it, sure, keep it; I don’t really care.


(Minor note, looking back at my image, the arrows are a bit short. The text about font size is in-fact referring to the font size of the dropdown list, nothing else.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-uiArea: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions