Windows 8 is returning ERROR_INVALID_HANDLE instead of NotFound when opening a missing file

[ehuss]

I tried this code:

use std::fs::File;
use std::io::ErrorKind;

fn main() {
    let err = File::open("foo").unwrap_err();
    assert_eq!(err.kind(), ErrorKind::NotFound);
}

I expected to see this happen: Runs without error.

Instead, this happened: On Windows 8, it fails with error:

thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `Uncategorized`,
 right: `NotFound`', src\main.rs:6:5

This seems to have started with #94572, cc @sunfishcode.

This is causing cargo new to fail on Windows 8, cc rust-lang/cargo#10464

This may also be responsible for rustc's incremental support to complain, though this doesn't always happen:

warning: could not load dep-graph from `\\?\C:\Temp\empty\target\debug\incremental\empty-2s9a0rpxj1834\s-g83mc5algm-1qawwn9-working\dep-graph.bin`: The handle is invalid. (os error 6)

Meta

rustc --version --verbose:

rustc 1.61.0-nightly (8d60bf427 2022-03-19)
binary: rustc
commit-hash: 8d60bf427a4b055f464122062e76b3ec34d4f8ba
commit-date: 2022-03-19
host: x86_64-pc-windows-msvc
release: 1.61.0-nightly
LLVM version: 14.0.0

[sunfishcode]

I unfortunately don't have a Windows 8 box to test this on, but looking at the code, I have a theory which would explain the behavior you're seeing here, and I've now posted a fix for it here: #95158.

[AndreKR]

This also happens on Windows 7 by the way.

[Mingun]

Confirming this on Windows 7, Windows 10 and 11 seems unaffected

[sunfishcode]

@AndreKR @Mingun @ehuss #95158 has now made it to the latest nightly Rust; would you mind testing whether it fixes this issue on Windows 7 and Windows 8?

[Mingun]

Yes, after updating to rustc 1.61.0-nightly (5f37001 2022-03-22) (from rustc 1.61.0-nightly (58f1179 2022-03-17)) issue seems fixed on Windows 7!

Previously:

> cargo fmt --check
Неверный дескриптор. (os error 6)

Fixed nightly:

> cargo fmt --check
Diff in \\?\H:\Projects\quick-xml\src\de\map.rs at line 198:
...skipped...

[AndreKR]

I can confirm that as well.

[sunfishcode]

Thanks! Now we just need a confirmation for Windows 8, just to be sure :-).

[apiraino]

Assigning priority as discussed in the Zulip thread of the Prioritization Working Group.

@rustbot label -I-prioritize +P-high