Skip to content

Add back help_on_error for download-ci-llvm #97503

Closed
@jyn514

Description

@jyn514

I accidentally missed this when porting it to rustbuild: https://github.com/rust-lang/rust/pull/95170/files#diff-9e25a089f077eae8c8cefe9586cc07498e64cd950be4c954cb90e4245e5f9fc3L634-L651

It would be nice to add it back.

Mentoring instructions: Add a new help_on_error parameter to Builder::download_component_helper and pass it down from download_ci_llvm:

pub(crate) fn download_component(&self, base: &str, url: &str, dest_path: &Path) {
builder.download_component(base, &format!("{}/{}", url, filename), &tarball);

This code moved around in #96687 so you may want to base your changes off that PR until it lands.

@rustbot label +E-easy +E-mentor +A-rustbuild

Metadata

Metadata

Assignees

Labels

E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions