Skip to content

Update minifier version to 0.2.2 #100624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

GuillaumeGomez
Copy link
Member

Following this PR, the CSS minification should be much faster now (thanks to @nnethercote).

r? @nnethercote

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 16, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2022
@nnethercote
Copy link
Contributor

Let's do a perf run to check:

@bors try @rust-timer queue

It's possible that the instruction counts will barely change. This is because memcpy is usually implemented using REP MOVSB on x86-64, which perf counts as a single instruction no matter how many bytes it copies. And this PR will avoid a relatively small number of memcpy calls that copy a lot of data.

If this is the case, hopefully the cycle counts will still be improved, which is the more important result.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2022
@bors
Copy link
Collaborator

bors commented Aug 16, 2022

⌛ Trying commit fb62f28 with merge a151ad6a4a6c2f42b1881c8b1bfeef4218fa3f1f...

@bors
Copy link
Collaborator

bors commented Aug 16, 2022

☀️ Try build successful - checks-actions
Build commit: a151ad6a4a6c2f42b1881c8b1bfeef4218fa3f1f (a151ad6a4a6c2f42b1881c8b1bfeef4218fa3f1f)

@rust-timer
Copy link
Collaborator

Queued a151ad6a4a6c2f42b1881c8b1bfeef4218fa3f1f with parent 14a459b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a151ad6a4a6c2f42b1881c8b1bfeef4218fa3f1f): comparison url.

Instruction count

  • Primary benchmarks: ✅ relevant improvements found
  • Secondary benchmarks: ✅ relevant improvements found
( ) mean1 max count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% -1.7% 14
Improvements ✅
(secondary)
-1.1% -1.7% 23
All ❌✅ (primary) -0.6% -1.7% 14

Max RSS (memory usage)

Results
  • Primary benchmarks: ❌ relevant regression found
  • Secondary benchmarks: mixed results
( ) mean1 max count2
Regressions ❌
(primary)
2.9% 2.9% 1
Regressions ❌
(secondary)
3.3% 3.3% 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.2% -1.2% 1
All ❌✅ (primary) 2.9% 2.9% 1

Cycles

Results
  • Primary benchmarks: ❌ relevant regression found
  • Secondary benchmarks: no relevant changes found
( ) mean1 max count2
Regressions ❌
(primary)
3.4% 3.4% 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.4% 3.4% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2022
@GuillaumeGomez
Copy link
Member Author

The result isn't great for memory usage and cycles.

@notriddle
Copy link
Contributor

Memory usage and cycles are pretty noisy. That's why instruction count is shown by default.

@nnethercote
Copy link
Contributor

Yes, the cycles and max-rss results look either neutral, or changes are too small to be detected within the noise. But instruction counts improved. A little surprising, but overall a good result. Thank you for filing the PR!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 16, 2022

📌 Commit fb62f28 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2022
@bors
Copy link
Collaborator

bors commented Aug 21, 2022

⌛ Testing commit fb62f28 with merge aa8e761...

@bors
Copy link
Collaborator

bors commented Aug 21, 2022

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing aa8e761 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2022
@bors bors merged commit aa8e761 into rust-lang:master Aug 21, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 21, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa8e761): comparison url.

Instruction count

  • Primary benchmarks: ✅ relevant improvements found
  • Secondary benchmarks: ✅ relevant improvements found
mean1 max count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% -1.6% 13
Improvements ✅
(secondary)
-1.1% -1.5% 20
All ❌✅ (primary) -0.6% -1.6% 13

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.1% 3.1% 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.8% -1.8% 2
All ❌✅ (primary) - - 0

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)
3.0% 3.0% 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% -2.8% 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.8% 3.0% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@GuillaumeGomez GuillaumeGomez deleted the update-minifier-version branch August 21, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants