-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update minifier version to 0.2.2 #100624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minifier version to 0.2.2 #100624
Conversation
Let's do a perf run to check: @bors try @rust-timer queue It's possible that the instruction counts will barely change. This is because If this is the case, hopefully the cycle counts will still be improved, which is the more important result. |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit fb62f28 with merge a151ad6a4a6c2f42b1881c8b1bfeef4218fa3f1f... |
☀️ Try build successful - checks-actions |
Queued a151ad6a4a6c2f42b1881c8b1bfeef4218fa3f1f with parent 14a459b, future comparison URL. |
Finished benchmarking commit (a151ad6a4a6c2f42b1881c8b1bfeef4218fa3f1f): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
The result isn't great for memory usage and cycles. |
Memory usage and cycles are pretty noisy. That's why instruction count is shown by default. |
Yes, the cycles and max-rss results look either neutral, or changes are too small to be detected within the noise. But instruction counts improved. A little surprising, but overall a good result. Thank you for filing the PR! @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (aa8e761): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Following this PR, the CSS minification should be much faster now (thanks to @nnethercote).
r? @nnethercote