Skip to content

Remove redundant all in cfg #104934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Conversation

ChrisDenton
Copy link
Member

This appears to have been accidentally left in after removing the other branches 45bf1ed

(hat tip to kangalioo for the git archaeology)

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2022

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 26, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2022

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

@ChrisDenton
Copy link
Member Author

Found a few more redundant cases.

@thomcc
Copy link
Member

thomcc commented Nov 26, 2022

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 26, 2022

📌 Commit 2ab3f76 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
…homcc

Remove redundant `all` in cfg

This appears to have been accidentally left in after removing the other branches rust-lang@45bf1ed

(hat tip to kangalioo for the git archaeology)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
…homcc

Remove redundant `all` in cfg

This appears to have been accidentally left in after removing the other branches rust-lang@45bf1ed

(hat tip to kangalioo for the git archaeology)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
…homcc

Remove redundant `all` in cfg

This appears to have been accidentally left in after removing the other branches rust-lang@45bf1ed

(hat tip to kangalioo for the git archaeology)
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2022
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#95836 (Use `rust_out{exe_suffix}` for doctests)
 - rust-lang#104882 (notify lcnr on changes to `ObligationCtxt`)
 - rust-lang#104892 (Explain how to get the discriminant out of a `#[repr(T)] enum` with payload)
 - rust-lang#104917 (Allow non-org members to label `requires-debug-assertions`)
 - rust-lang#104931 (Pretty-print generators with their `generator_kind`)
 - rust-lang#104934 (Remove redundant `all` in cfg)
 - rust-lang#104944 (Support unit tests for jsondoclint)
 - rust-lang#104946 (rustdoc: improve popover focus handling JS)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8d90647 into rust-lang:master Nov 27, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 27, 2022
@ChrisDenton ChrisDenton deleted the all-anybody-wants branch November 27, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants