-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add type flags support for Ty
and Const
late-bound variables
#105733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit d2ef902bd7dbc6ee89ea5efc685a6b3aa37149de with merge 0bc47f1d657456dfa37c363688b7d3f1b19ac8a0... |
Ty
and Const
late-bound regionsTy
and Const
late-bound variables
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (0bc47f1d657456dfa37c363688b7d3f1b19ac8a0): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Could you elaborate the use case for these |
@cjgillot yeah, predicates are probably the only place they make sense in the language currently. |
r=me with @fbstj's suggestion applied. |
d2ef902
to
3c41003
Compare
@bors r=cjgillot |
⌛ Testing commit 3c41003 with merge a8686e450a79735ad18881a34475383b5dcd059f... |
💥 Test timed out |
@bors retry That test timeout looks spurious? |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e6485ed): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
I've been working on
for<T>
binders, and these will eventually be useful.