Skip to content

[experiment] Get rid of pending_obligations #106073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[experiment] Get rid of pending_obligations #106073

wants to merge 4 commits into from

Conversation

compiler-errors
Copy link
Member

Currently has some issues:

  • Autoderef still needs to do some fulfillment, to make sure that the autoderef chain doesn't stall on an inference variable
    • We may be able to move the fulfillment in method_autoderef_steps or somewhere else where this particularly matters...
  • The explicit_item_bounds of an RPITIT need to be normalized before being registered
    • Probably all bounds could be normalized here, there are likely ways of making this break in RPIT too...

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2022
@compiler-errors
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Dec 23, 2022

⌛ Trying commit 9a826cc with merge d4bd6c543d189dee2fa075d0b37e31ddc7d111a4...

@bors
Copy link
Collaborator

bors commented Dec 23, 2022

☀️ Try build successful - checks-actions
Build commit: d4bd6c543d189dee2fa075d0b37e31ddc7d111a4 (d4bd6c543d189dee2fa075d0b37e31ddc7d111a4)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-106073 created and queued.
🤖 Automatically detected try build d4bd6c543d189dee2fa075d0b37e31ddc7d111a4
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment pr-106073 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-106073 is completed!
📊 106 regressed and 12 fixed (250762 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 24, 2022
@compiler-errors
Copy link
Member Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 27, 2023

@compiler-errors this has been open a while - are you still planning to follow up on it?

@compiler-errors
Copy link
Member Author

Yeah

@Dylan-DPC
Copy link
Member

Closing this as it has been inactive

@Dylan-DPC Dylan-DPC closed this Jul 30, 2023
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2023
@compiler-errors compiler-errors deleted the obliterate-pending_obligations branch August 11, 2023 20:12
@compiler-errors compiler-errors mentioned this pull request Oct 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @bors @craterbot @jyn514 @Dylan-DPC @rustbot