Rework Bounds collection

[compiler-errors]

I think it's weird for the Bounds struct in astconv to store its predicates almost converted into real predicates... so we do this eagerly, instead of lazily.

[rustbot]

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 8a8c8f233bb8fb76f1af8ecd99578afb3c773e6e with merge b91d9369c823d55819e539d191ee8a4af51d2fdf...

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 520b5fa with merge 299832898946e6df1f23e3811fba2c45d7086a84...

[bors]

☀️ Try build successful - checks-actions
Build commit: 299832898946e6df1f23e3811fba2c45d7086a84 (299832898946e6df1f23e3811fba2c45d7086a84)

[rust-timer]

Finished benchmarking commit (299832898946e6df1f23e3811fba2c45d7086a84): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	2
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[davidtwco]

@bors r+

[bors]

📌 Commit 520b5fa has been approved by davidtwco

It is now in the queue for this repository.

[bors]

⌛ Testing commit 520b5fa with merge fa51fc0...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing fa51fc0 to master...

[rust-timer]

Finished benchmarking commit (fa51fc0): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.8%, -0.7%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.