Skip to content

Added link from Targets to Platform Support in the book #106312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2023

Conversation

tgross35
Copy link
Contributor

If you search the web for "rust targets", the first result is the targets page. However, usually when searching for this I'm interested in seeing the available triples with host information, so I just added a link to the correct page.

The entire Targets chapter could probably be combined into one page, since its three subchapters each only have a tiny section (I'll do this if requested)

@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2022
@tgross35
Copy link
Contributor Author

@rustbot label +A-docs

@rustbot rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Dec 30, 2022
@GuillaumeGomez
Copy link
Member

r? rust-lang/libs

@rustbot rustbot assigned m-ou-se and unassigned GuillaumeGomez Dec 31, 2022
@JohnTitor
Copy link
Member

Makes sense to me, thank you!

The entire Targets chapter could probably be combined into one page, since its three subchapters each only have a tiny section (I'll do this if requested)

The current looks great enough to me so I'm going to merge as-is.
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 1, 2023

📌 Commit a582919 has been approved by JohnTitor

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2023
@bors
Copy link
Collaborator

bors commented Jan 1, 2023

⌛ Testing commit a582919 with merge bb6e76d...

@tgross35
Copy link
Contributor Author

tgross35 commented Jan 1, 2023

Awesome, thanks!

@bors
Copy link
Collaborator

bors commented Jan 1, 2023

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing bb6e76d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2023
@bors bors merged commit bb6e76d into rust-lang:master Jan 1, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 1, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bb6e76d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.9% [-3.9%, -3.9%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@tgross35 tgross35 deleted the update-book-target branch January 22, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants