Skip to content

Implement fix for #67535 #106358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2023
Merged

Implement fix for #67535 #106358

merged 1 commit into from
Jan 2, 2023

Conversation

TroyNeubauer
Copy link
Contributor

Implements a fix for #67535
r? @estebank

@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 2, 2023
@estebank
Copy link
Contributor

estebank commented Jan 2, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 2, 2023

📌 Commit 4cb9030 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023
@bors
Copy link
Collaborator

bors commented Jan 2, 2023

⌛ Testing commit 4cb9030 with merge c5cb156...

@bors
Copy link
Collaborator

bors commented Jan 2, 2023

☀️ Test successful - checks-actions
Approved by: estebank
Pushing c5cb156 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2023
@bors bors merged commit c5cb156 into rust-lang:master Jan 2, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 2, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c5cb156): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 11.1% [11.1%, 11.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.6% [-3.9%, -3.3%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@TroyNeubauer TroyNeubauer deleted the improve-foreign-orphan-error branch January 2, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@TroyNeubauer @rustbot @estebank @bors @rust-timer