-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix: don't emit E0711
if staged_api
not enabled
#106627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
8041bff
to
f4afc42
Compare
@Mark-Simulacrum I've applied your suggestion. @rustbot ready |
@bors r+ rollup=never (perf) |
📌 Commit f4afc42a0661e23cfcf1483ba54bc8c63e000644 has been approved by It is now in the queue for this repository. |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
f4afc42
to
be1a6db
Compare
@Mark-Simulacrum Had to rebase because @rustbot ready |
@bors r=Mark-Simulacrum |
☀️ Test successful - checks-actions |
Finished benchmarking commit (159ba8a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Fixes #106589
Simple fix, added UI test.
As an aside, it seems a lot of features are susceptible to this,
E0711
stands out to me because it's perma-unstable and we are effectively exposing an implementation detail.