Skip to content

Revert new naming #10796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2013
Merged

Revert new naming #10796

merged 3 commits into from
Dec 5, 2013

Conversation

lilyball
Copy link
Contributor

@lilyball lilyball commented Dec 4, 2013

Rename the *::init() functions back to *::new(), since new is not
going to become a keyword.

@lilyball
Copy link
Contributor Author

lilyball commented Dec 4, 2013

Running the rustpkg tests with logging, I see

/private/var/folders/cs/l6c6g06x0974_0w5pdg8dps80000gn/T/qPOPMYz68t9RECSptemp_workspace/src/cdep-0.1/main.rs:2:0: 2:18 error: the `link_args` attribute is not portable across platforms, it is recommended to use `#[link(name = "foo")]` instead
/private/var/folders/cs/l6c6g06x0974_0w5pdg8dps80000gn/T/qPOPMYz68t9RECSptemp_workspace/src/cdep-0.1/main.rs:2 extern { fn f(); } 
                                                                                                               ^~~~~~~~~~~~~~~~~~

This error is completely unrelated to my PR. Why isn't this test failing every single PR?

@lilyball
Copy link
Contributor Author

lilyball commented Dec 4, 2013

@alexcrichton I had to force-push to update the Path::new commit to include the #[ignore]s that were added to the rustpkg tests in the reverted commit. Can you r+ again?

@lilyball
Revert "libstd: Change Path::new to Path::init."
408dc5a 
This reverts commit c54427d.

Leave the #[ignores] in that were added to rustpkg tests.

Conflicts:
	src/librustc/driver/driver.rs
	src/librustc/metadata/creader.rs
@lilyball
Rename extra::json::*::init() constructors to *::new()
2c4a1b5
@lilyball
Rename std::rt::deque::*::init() to *::new()
b170571
@lilyball
Copy link
Contributor Author

lilyball commented Dec 5, 2013

Updated due to bitrot. r? @alexcrichton

bors added a commit that referenced this pull request Dec 5, 2013
@bors
auto merge of #10796 : kballard/rust/revert-new-naming, r=alexcrichton
b5bab85 
Rename the `*::init()` functions back to `*::new()`, since `new` is not
going to become a keyword.
@bors bors closed this Dec 5, 2013
@bors bors merged commit b170571 into rust-lang:master Dec 5, 2013
chris-morgan added a commit to chris-morgan/rust-http that referenced this pull request Dec 5, 2013
@chris-morgan
Update for rust-lang/rust#10796.
c19fef8
@lilyball lilyball deleted the revert-new-naming branch December 10, 2013 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilyball @alexcrichton @bors