Skip to content

Add ConstParamTy trait #108161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 2, 2023
Merged

Add ConstParamTy trait #108161

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
518d348
Implement `StructuralEq` for integers, `bool` and `char`
WaffleLapkin Feb 17, 2023
9a716da
Add a `ConstParamTy` trait
WaffleLapkin Feb 17, 2023
c8844e1
`derive(Eq)` in a test
WaffleLapkin Feb 22, 2023
81a2b85
Remove `feature(const_param_ty_trait)`, use `adt_const_params` instead
WaffleLapkin Feb 22, 2023
c45c4f2
Rename/move a test
WaffleLapkin Feb 22, 2023
1c54410
Check the correct trait when checking `ConstParamTy` impls
WaffleLapkin Feb 23, 2023
7234d63
Add `!StructuralEq` test for `ConstParamTy`
WaffleLapkin Feb 23, 2023
2205c3f
Add a macro to conveniently implement marker traits
WaffleLapkin Mar 3, 2023
1bf6bbb
Impl `StructuralEq` & `ConstParamTy` for `str`, `&T`, `[T; N]` and `[T]`
WaffleLapkin Mar 3, 2023
2c5e716
Add FIXMEs
WaffleLapkin Mar 3, 2023
51355ad
Add a test for `[NotParam; 0]: ConstParamTy` (not holding)
WaffleLapkin Mar 3, 2023
bdb5502
Fix some marker impls
WaffleLapkin Mar 3, 2023
26417a8
Add `ConstParamTy` tests
WaffleLapkin Mar 3, 2023
2f70d02
Fix compile test so it normalizes (un)expected error messages
WaffleLapkin Apr 27, 2023
1f44a24
--bless `ConstParamTy` ui tests
WaffleLapkin Apr 27, 2023
182eee2
fixup tests wrt new normalization
WaffleLapkin Apr 28, 2023
c317546
Fix `StructuralEq` impls for `&T`, `[T]` and `[T; N]`
WaffleLapkin May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/ui/const-generics/nested-type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#![cfg_attr(full, feature(adt_const_params))]
#![cfg_attr(full, allow(incomplete_features))]

struct Foo<const N: [u8; { //[min]~ ERROR `[u8; _]` is forbidden
struct Foo<const N: [u8; {
struct Foo<const N: usize>;

impl<const N: usize> Foo<N> {
Expand All @@ -15,5 +15,9 @@ struct Foo<const N: [u8; { //[min]~ ERROR `[u8; _]` is forbidden
Foo::<17>::value()
//~^ ERROR cannot call non-const fn
}]>;
//[min]~^^^^^^^^^^^^ ERROR `[u8; {

// N.B. it is important that the comment above is not inside the array length,
// otherwise it may check for itself, instead of the actual error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is hilarious actually
nice find :)


fn main() {}
2 changes: 1 addition & 1 deletion tests/ui/fmt/format-string-error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ fn main() {
let _ = format!("}");
//~^ ERROR invalid format string: unmatched `}` found
let _ = format!("{\\}");
//~^ ERROR invalid format string: expected `'}'`, found `'\\'`
//~^ ERROR invalid format string: expected `'}'`, found `'\'`
let _ = format!("\n\n\n{\n\n\n");
//~^ ERROR invalid format string
let _ = format!(r###"
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/parser/issues/issue-62913.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"\u\\"
//~^ ERROR incorrect unicode escape sequence
//~| ERROR invalid trailing slash in literal
//~| ERROR expected item, found `"\u\\"`
//~| ERROR expected item, found `"\u\"`