MIR-Validate StorageLive.

[cjgillot]

StorageLive statements on a local which already has storage is banned by miri.

This check is easy enough, and can detect bugs in MIR opts.

[rustbot]

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

[tmiasko]

@bors try

[bors]

⌛ Trying commit 81ebbfa7113eb2dce2a68064061dbcdb8522734a with merge 47a7405fd6f67fc959d6d12979f06fb1b5dcafac...

[bors]

☀️ Try build successful - checks-actions
Build commit: 47a7405fd6f67fc959d6d12979f06fb1b5dcafac (47a7405fd6f67fc959d6d12979f06fb1b5dcafac)

[wesleywiser]

I assume we want a perf run:

@rust-timer build 47a7405fd6f67fc959d6d12979f06fb1b5dcafac

[rust-timer]

Finished benchmarking commit (47a7405fd6f67fc959d6d12979f06fb1b5dcafac): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

[wesleywiser]

r=me with @tmiasko's suggestion applied

[tmiasko]

@bors r+

[bors]

📌 Commit bf46b9c has been approved by tmiasko

It is now in the queue for this repository.

[bors]

⌛ Testing commit bf46b9c with merge 7d782b7...

[bors]

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 7d782b7 to master...

[rust-timer]

Finished benchmarking commit (7d782b7): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.7%]	3
Regressions ❌ (secondary)	0.3%	[0.3%, 0.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.6%, 0.7%]	3

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

[pnkfelix]

• MIR-Validate StorageLive. #108175 regressed helloworld check by 0.6% in three incremental scenarios.
• note though that these regressions did not show up in the timer run before the PR landed.
• marking as triaged.

@rustbot label: perf-regression-triaged