Upgrade to ena-0.14.1.

[nnethercote]

It avoids some inlining within its inlined_probe_value function, which seems to result in better codegen for the very large process_obligations function within rustc. It might also help with reducing the bimodal perf results we see for the keccak and cranelift-codegen-0.82.1 benchmarks.

r? @ghost

[rustbot]

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

[nnethercote]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 50f4ac32b07d8464d58d5ef0dd7fc8310d970bfd with merge 4785ae1d9ecfdd6ccced95f65a2e6371377a510e...

[nnethercote]

@bors try @rust-timer queue

[bors]

⌛ Trying commit ee1e0e26c9d6af19d60bbb52cdfa097d7b3f3378 with merge 55467287b500fdb768ab16ccf6195eab4c4d233a...

[bors]

💔 Test failed - checks-actions

[nnethercote]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 87f2860a20013cfdfab7d72feaf914ea05561ba4 with merge d5269b225d4942eed38661728de3c08a427d0002...

[bors]

☀️ Try build successful - checks-actions
Build commit: d5269b225d4942eed38661728de3c08a427d0002 (d5269b225d4942eed38661728de3c08a427d0002)

[rust-timer]

Finished benchmarking commit (d5269b225d4942eed38661728de3c08a427d0002): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-2.2%, -0.7%]	3
Improvements ✅ (secondary)	-3.4%	[-5.0%, -0.3%]	8
All ❌✅ (primary)	-1.6%	[-2.2%, -0.7%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.3%	[-3.5%, -3.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.3%	[-3.5%, -3.0%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	9.4%	[8.9%, 9.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

[nnethercote]

Perf results look good, though it's a bit hard to tell because keccak and cranelift have been noisy lately. Having said that, the check-full results for both have been much more stable over the past 3 days, and the check-full results in the perf run above have icounts lower than we have seen before.

[nnethercote]

Let's try again.

@bors try @rust-timer queue

[joshtriplett]

@bors r+ rollup=never

[bors]

📌 Commit d78ca52 has been approved by joshtriplett

It is now in the queue for this repository.

[bors]

⌛ Testing commit d78ca52 with merge 619bad5e18705eb69c1e5145cbbb023b97264d57...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job i686-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2527/3021] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/LogBuilderConsumer.cpp.obj
[2528/3021] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/Trace.cpp.obj
[2529/3021] Linking CXX static library lib\libLLVMDlltoolDriver.a
FAILED: lib/libLLVMDlltoolDriver.a 
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E rm -f lib\libLLVMDlltoolDriver.a && D:\a\rust\rust\mingw32\bin\ar.exe qc lib\libLLVMDlltoolDriver.a  lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.obj && D:\a\rust\rust\mingw32\bin\ranlib.exe lib\libLLVMDlltoolDriver.a && cd ."
D:\a\rust\rust\mingw32\bin\ar.exe: could not create temporary file whilst writing archive: no more archived files
[2530/3021] Linking CXX static library lib\libLLVMDebugInfoDWARF.a
[2531/3021] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/RecordInitializer.cpp.obj
[2532/3021] Linking CXX static library lib\libLLVMRuntimeDyld.a
[2533/3021] Linking CXX static library lib\libLLVMJITLink.a
[2533/3021] Linking CXX static library lib\libLLVMJITLink.a
[2534/3021] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/Profile.cpp.obj
[2535/3021] Linking CXX static library lib\libLLVMObjectYAML.a
[2536/3021] Linking CXX static library lib\libLLVMDebugInfoPDB.a
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1cd66030c949c28d\cmake-0.1.48\src\lib.rs:975:5
 finished in 283.270 seconds
Build completed unsuccessfully in 0:08:11
Build completed unsuccessfully in 0:08:11
make: *** [Makefile:78: ci-mingw-subset-1] Error 1

[nnethercote]

@bors retry

[bors]

⌛ Testing commit d78ca52 with merge dfa5643...

[bors]

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing dfa5643 to master...

[rust-timer]

Finished benchmarking commit (dfa5643): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-3.4%, -3.4%]	1
Improvements ✅ (secondary)	-4.8%	[-4.8%, -4.8%]	1
All ❌✅ (primary)	-3.4%	[-3.4%, -3.4%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[nnethercote]

The perf CI run said there were no relevant improvements, but that's because keccak is so noisy that the benchmark harness's thresholds for it are around 7-10%(!) But I think there was a genuine improvement for keccak. E.g. consider the check-full graph:

The highlighted data point is the measurement after this PR merged, and it's clearly lower than anything we've seen in the past month. Maybe it'll also help fix the bimodality? Fingers crossed.

(There is a similar story for cranelift-codegen, though the effect is smaller and a little less clear, because the obligation processing accounts for a smaller fraction of its compilation time.)

[nnethercote]

We now have 12 data points since this PR merged, and both keccak and cranelift-codegen have been stable. Yay!