Skip to content

binary_heap: Optimize Extend implementation. #108448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2023
Merged

binary_heap: Optimize Extend implementation. #108448

merged 2 commits into from
Apr 3, 2023
+19 −51

Conversation

ishitatsuyuki
Copy link
Contributor

This PR makes the Extend implementation for BinaryHeap no longer rely on specialization, so that it always use the bulk rebuild optimization that was previously only available for the Vec specialization.

@ishitatsuyuki
binary_heap: Make RebuildOnDrop a common helper.
11c589c 
This helper was written for retain() but will also be useful for extend().
@ishitatsuyuki
binary_heap: Unify Extend implementation.
116bb4d 
Previously the bulk rebuild specialization was only available with Vec, and
for general iterators Extend only provided pre-allocation through reserve().

By using a drop guard, we can safely bulk rebuild even if the iterator may
panic. This allows benefiting from the bulk rebuild optimization without
collecting iterator elements into a Vec beforehand, which would nullify any
performance gains from bulk rebuild.
@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@ishitatsuyuki
Copy link
Contributor Author

Anyone around for review?

@ishitatsuyuki
Copy link
Contributor Author

r? libs

@rustbot rustbot assigned joshtriplett and unassigned m-ou-se Mar 9, 2023
@ishitatsuyuki
Copy link
Contributor Author

r? libs

@rustbot rustbot assigned thomcc and unassigned joshtriplett Mar 20, 2023
@thomcc
Copy link
Member

thomcc commented Mar 21, 2023

Not familiar with binary heap internals.

r? libs

@rustbot rustbot assigned Mark-Simulacrum and unassigned thomcc Mar 21, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2023

📌 Commit 116bb4d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2023
@bors
Copy link
Collaborator

bors commented Apr 3, 2023

⌛ Testing commit 116bb4d with merge f13ccef...

@bors
Copy link
Collaborator

bors commented Apr 3, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f13ccef to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 3, 2023
@bors bors merged commit f13ccef into rust-lang:master Apr 3, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 3, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f13ccef): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.0% [1.2%, 2.7%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ishitatsuyuki @rustbot @thomcc @Mark-Simulacrum @bors @rust-timer @joshtriplett @m-ou-se