Skip to content

Move THIR printing to rustc_mir_build. #108493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

cjgillot
Copy link
Contributor

#107451 increased the compilation time of rustc_middle by 10% = 3s.

As #107006 adds quite a lot of code to rustc_middle, I suspect it to be the cause.

This PR moves the THIR printing code to rustc_mir_build, where the query provider lives, in order to benefit from higher parallelism when compiling rustc.

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 26, 2023
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2023
@bors
Copy link
Collaborator

bors commented Feb 26, 2023

⌛ Trying commit 380ca0c with merge efe988676fe0b79db5fd33ef6e99ea0986738ba9...

@bors
Copy link
Collaborator

bors commented Feb 26, 2023

☀️ Try build successful - checks-actions
Build commit: efe988676fe0b79db5fd33ef6e99ea0986738ba9 (efe988676fe0b79db5fd33ef6e99ea0986738ba9)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (efe988676fe0b79db5fd33ef6e99ea0986738ba9): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.3%, 0.3%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2023
@compiler-errors
Copy link
Member

Cool, makes sense. Thanks!

r? @compiler-errors @bors r+

@bors
Copy link
Collaborator

bors commented Feb 26, 2023

📌 Commit 380ca0c has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned oli-obk Feb 26, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
@bors
Copy link
Collaborator

bors commented Feb 27, 2023

⌛ Testing commit 380ca0c with merge f540a25...

@bors
Copy link
Collaborator

bors commented Feb 27, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f540a25 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Feb 27, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f540a25 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Feb 27, 2023
@bors bors merged commit f540a25 into rust-lang:master Feb 27, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 27, 2023
@cjgillot cjgillot deleted the thir-print branch February 27, 2023 18:13
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f540a25): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.3%, 0.3%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants