Remove `allow(potential_query_instability)` from `borrowck` #108735

clubby789 · 2023-03-04T12:43:50Z

Replace uses of FxHash* with FxIndex*. One #[allow] for a HashMap in an external crate but the output is sorted afterwards.

rustbot · 2023-03-04T12:43:55Z

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

Noratrieb · 2023-03-04T13:26:31Z

@bors try @rust-timer queue

bors · 2023-03-04T13:26:40Z

⌛ Trying commit 4b312c26b16a5a6c53e3481ea16d3833e89e1bc0 with merge f3bd67df794dd08613dcb4c3bd1c5eb9364dd901...

bors · 2023-03-04T15:37:03Z

☀️ Try build successful - checks-actions
Build commit: f3bd67df794dd08613dcb4c3bd1c5eb9364dd901 (f3bd67df794dd08613dcb4c3bd1c5eb9364dd901)

bors · 2023-03-04T15:37:03Z

☀️ Try build successful - checks-actions
Build commit: f3bd67df794dd08613dcb4c3bd1c5eb9364dd901 (f3bd67df794dd08613dcb4c3bd1c5eb9364dd901)

rust-timer · 2023-03-04T17:23:00Z

Finished benchmarking commit (f3bd67df794dd08613dcb4c3bd1c5eb9364dd901): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.3%, 0.7%]	12
Regressions ❌ (secondary)	0.5%	[0.2%, 0.6%]	10
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.2%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.3%, 0.7%]	18

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.3%, 2.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-5.4%, -1.1%]	18
All ❌✅ (primary)	1.8%	[1.3%, 2.3%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.0%, 2.5%]	11
Regressions ❌ (secondary)	1.8%	[1.1%, 2.5%]	25
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.0%, 2.5%]	11

Noratrieb · 2023-03-05T18:58:16Z

@bors try @rust-timer queue

bors · 2023-03-05T18:58:25Z

⌛ Trying commit fe6bd32b6cde023d5eed374d83cb013483ac36f4 with merge e2fc320fee9b28723be2c4208f2665653e48c3e0...

Noratrieb · 2023-03-05T19:39:19Z

i think it's fine to try again after a force push? we'll see, worst case you have to reopen the PR :D
@bors try @rust-timer queue

bors · 2023-03-05T19:39:28Z

⌛ Trying commit 3eeb3fd with merge cd9ce09752921639ef140ece6de524ce744ff5be...

bors · 2023-03-05T21:34:49Z

☀️ Try build successful - checks-actions
Build commit: cd9ce09752921639ef140ece6de524ce744ff5be (cd9ce09752921639ef140ece6de524ce744ff5be)

Noratrieb · 2023-03-06T07:05:01Z

@rust-timer build cd9ce09752921639ef140ece6de524ce744ff5be

Noratrieb · 2023-03-06T07:29:07Z

i think it's fine to try again after a force push?

i guess it wasnt, too bad

rust-timer · 2023-03-06T08:45:55Z

Finished benchmarking commit (cd9ce09752921639ef140ece6de524ce744ff5be): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.0%, 1.2%]	2
Regressions ❌ (secondary)	1.8%	[0.2%, 2.6%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	1.1%	[1.0%, 1.2%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Noratrieb · 2023-03-06T13:24:20Z

compiler/rustc_borrowck/src/type_check/input_output.rs

@@ -19,7 +19,7 @@ use super::{Locations, TypeChecker};

 impl<'a, 'tcx> TypeChecker<'a, 'tcx> {
    /// Check explicit closure signature annotation,
-    /// e.g., `|x: FxHashMap<_, &'static u32>| ...`.
+    /// e.g., `|x: FxIndexMap<_, &'static u32>| ...`.


Noratrieb · 2023-03-06T13:24:41Z

the usual obligation processing noise
@bors r+

bors · 2023-03-06T13:24:43Z

📌 Commit 3eeb3fd has been approved by Nilstrieb

It is now in the queue for this repository.

bors · 2023-03-07T07:02:01Z

⌛ Testing commit 3eeb3fd with merge 8f9e09a...

bors · 2023-03-07T09:42:29Z

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 8f9e09a to master...

bors · 2023-03-07T09:42:29Z

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 8f9e09a to master...

rust-timer · 2023-03-07T11:02:36Z

Finished benchmarking commit (8f9e09a): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.3%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[-1.4%, 3.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.2%, 3.9%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.6%	[3.2%, 3.9%]	2

rustbot assigned Noratrieb Mar 4, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 4, 2023

clubby789 force-pushed the borrowck-unstable branch from 4b312c2 to fe6bd32 Compare March 5, 2023 18:54

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 5, 2023

Remove allow(potential_query_instability) from borrowck

3eeb3fd

clubby789 force-pushed the borrowck-unstable branch from fe6bd32 to 3eeb3fd Compare March 5, 2023 18:59

This comment has been minimized.

Sign in to view

Noratrieb closed this Mar 6, 2023

Noratrieb reopened this Mar 6, 2023

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2023

Noratrieb reviewed Mar 6, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2023

Noratrieb added the perf-regression-triaged The performance regression has been triaged. label Mar 6, 2023

bors added merged-by-bors This PR was explicitly merged by bors. labels Mar 7, 2023

bors merged commit 8f9e09a into rust-lang:master Mar 7, 2023

rustbot added this to the 1.70.0 milestone Mar 7, 2023

rustbot removed the perf-regression Performance regression. label Mar 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `allow(potential_query_instability)` from `borrowck` #108735

Remove `allow(potential_query_instability)` from `borrowck` #108735

clubby789 commented Mar 4, 2023

rustbot commented Mar 4, 2023

Noratrieb commented Mar 4, 2023

This comment has been minimized.

bors commented Mar 4, 2023

bors commented Mar 4, 2023

bors commented Mar 4, 2023

This comment has been minimized.

rust-timer commented Mar 4, 2023

Noratrieb commented Mar 5, 2023

This comment has been minimized.

bors commented Mar 5, 2023

Noratrieb commented Mar 5, 2023

This comment has been minimized.

bors commented Mar 5, 2023

bors commented Mar 5, 2023

This comment has been minimized.

Noratrieb commented Mar 6, 2023

This comment has been minimized.

Noratrieb commented Mar 6, 2023 •

edited

Loading

rust-timer commented Mar 6, 2023

Noratrieb Mar 6, 2023

Noratrieb commented Mar 6, 2023

bors commented Mar 6, 2023

bors commented Mar 7, 2023

bors commented Mar 7, 2023

bors commented Mar 7, 2023

rust-timer commented Mar 7, 2023

Remove allow(potential_query_instability) from borrowck #108735

Remove allow(potential_query_instability) from borrowck #108735

Conversation

clubby789 commented Mar 4, 2023

rustbot commented Mar 4, 2023

Noratrieb commented Mar 4, 2023

This comment has been minimized.

bors commented Mar 4, 2023

bors commented Mar 4, 2023

bors commented Mar 4, 2023

This comment has been minimized.

rust-timer commented Mar 4, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Noratrieb commented Mar 5, 2023

This comment has been minimized.

bors commented Mar 5, 2023

Noratrieb commented Mar 5, 2023

This comment has been minimized.

bors commented Mar 5, 2023

bors commented Mar 5, 2023

This comment has been minimized.

Noratrieb commented Mar 6, 2023

This comment has been minimized.

Noratrieb commented Mar 6, 2023 • edited Loading

rust-timer commented Mar 6, 2023

Overall result: ❌ regressions - ACTION NEEDED

Choose a reason for hiding this comment

Noratrieb commented Mar 6, 2023

bors commented Mar 6, 2023

bors commented Mar 7, 2023

bors commented Mar 7, 2023

bors commented Mar 7, 2023

rust-timer commented Mar 7, 2023

Overall result: ❌✅ regressions and improvements - no action needed

Remove `allow(potential_query_instability)` from `borrowck` #108735

Remove `allow(potential_query_instability)` from `borrowck` #108735

Noratrieb commented Mar 6, 2023 •

edited

Loading