Skip to content

diagnostics: account for glob shadowing when linting redundant imports #109599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2023
Merged

diagnostics: account for glob shadowing when linting redundant imports #109599

merged 2 commits into from
Apr 4, 2023

Conversation

notriddle
Copy link
Contributor

Fixes #92904

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2023

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2023
@petrochenkov petrochenkov self-assigned this Mar 25, 2023
@lcnr
Copy link
Contributor

lcnr commented Mar 27, 2023

r? compiler

@rustbot rustbot assigned cjgillot and unassigned petrochenkov and lcnr Mar 27, 2023
@lcnr
Copy link
Contributor

lcnr commented Mar 27, 2023

r? @petrochenkov woops

@rustbot rustbot assigned petrochenkov and unassigned cjgillot Mar 27, 2023
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2023
@notriddle notriddle force-pushed the notriddle/use-redundant-glob branch from 0af21b1 to 7d303ba Compare March 30, 2023 05:00
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@notriddle notriddle force-pushed the notriddle/use-redundant-glob branch from 7d303ba to 4f3d26b Compare March 30, 2023 05:07
@notriddle
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2023
@notriddle notriddle changed the title diagnostics: do not mark import that shadows glob as redundant diagnostics: account for glob shadowing when linting redundant imports Mar 30, 2023
petrochenkov
petrochenkov reviewed Mar 30, 2023
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2023
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2023
@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 31, 2023
@notriddle notriddle force-pushed the notriddle/use-redundant-glob branch from c3ef027 to 6b1af80 Compare April 1, 2023 18:09
@notriddle notriddle force-pushed the notriddle/use-redundant-glob branch from 6b1af80 to 000e94e Compare April 1, 2023 18:11
@notriddle
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 3, 2023

📌 Commit 000e94e has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2023
@bors
Copy link
Collaborator

bors commented Apr 4, 2023

⌛ Testing commit 000e94e with merge 35d06f9...

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 35d06f9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2023
@bors bors merged commit 35d06f9 into rust-lang:master Apr 4, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 4, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (35d06f9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.1% [1.0%, 1.2%] 4
Regressions ❌
(secondary)		 1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.0% [-1.0%, -1.0%] 2
All ❌✅ (primary) 1.1% [1.0%, 1.2%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

@notriddle notriddle deleted the notriddle/use-redundant-glob branch April 4, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

rustc incorrectly suggests removing imports that shadow shadowing glob imports
8 participants
@notriddle @rustbot @lcnr @rust-log-analyzer @petrochenkov @bors @rust-timer @cjgillot